-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fondant base image #801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Matthias!
Do we also plan on providing base fondant pytorch images for CUDA components? I guess there we'll have to make more limited choices (which pytorch version, python versions are limited)
I thought about this. I guess we don't need them right now. It can be quite complex and I think when people start using the GPU we should recommend building a custom component the old way. This components won't be lightweight neither. |
alright makes sense! Some tests still to be failing though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Tested the build process in one of the latest commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looking very good!
Btw I tested the base image in a local pipeline and it worked fine!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thx
How come I only see 1 tag on docker hub ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrchtr!
Left some small comments, but looks good!
For the name of the images, I would propose just fondant
, and I would abbreviate the python versions to eg. py3.11.
The PR contains the docker file for the base image and adjusts the code to use the base image for the python components.
Up for a better naming of the base image. Currently I've used
fndnt/fondant-base:fondant_version-python_version
,e.g.
fndnt/fondant-base:0.9.0-python3.10
Fix #782